2 Commits

Author SHA1 Message Date
Alexander Heldt
a3c5c203f1 wip set view 2025-12-25 17:51:32 +01:00
Alexander Heldt
0ef94d7c89 Key handling is state aware
By forwarding all `Key`s to the agent and allow it to decide what should
be done, instead of converting the `Key` to a `Control` and then decide
what should be done
2025-12-25 17:49:34 +01:00
5 changed files with 92 additions and 133 deletions

View File

@@ -1,19 +1,15 @@
import gleam/string
import musicplayer/input/key.{type Key} import musicplayer/input/key.{type Key}
pub type Mode { pub type Mode {
Idle Idle
Searching Searching(input: String)
} }
pub type Control { pub type Control {
InputKey(Key)
TogglePlayPause TogglePlayPause
Search Search(input: String, capturing: Bool)
Raw(String)
Return
Backspace
Exit Exit
} }
@@ -21,24 +17,35 @@ pub type Control {
pub fn from_key(key: Key, mode: Mode) -> Result(Control, Nil) { pub fn from_key(key: Key, mode: Mode) -> Result(Control, Nil) {
case mode { case mode {
Idle -> idle_from_key(key) Idle -> idle_from_key(key)
Searching -> todo Searching(input) -> searching_from_key(key, input)
} }
} }
pub fn idle_from_key(key: Key) -> Result(Control, Nil) { pub fn idle_from_key(key: Key) -> Result(Control, Nil) {
case key { case key {
key.Return -> Ok(Return) key.Char(char) -> {
key.Backspace -> Ok(Backspace) case char {
key.Char(char) -> Ok(idle_char_control(char)) " " -> Ok(TogglePlayPause)
"/" -> Ok(Search(input: "", capturing: True))
"q" -> Ok(Exit)
// NOOP
_ -> Error(Nil)
}
}
// NOOP
_ -> Error(Nil) _ -> Error(Nil)
} }
} }
fn idle_char_control(char: String) -> Control { pub fn searching_from_key(key: Key, input: String) -> Result(Control, Nil) {
case char { case key {
" " -> TogglePlayPause key.Char(char) -> Ok(Search(input <> char, True))
"/" -> Search key.Backspace -> Ok(Search(string.drop_end(input, 1), True))
"q" -> Exit key.Return -> Ok(Search(input, False))
_ -> Raw(char)
// NOOP
_ -> Error(Nil)
} }
} }

View File

@@ -2,7 +2,7 @@ import gleam/erlang/process.{type Name, type Pid, type Subject}
import gleam/otp/actor import gleam/otp/actor
import gleam/string import gleam/string
import musicplayer/control.{type Control, type Mode} import musicplayer/control.{type Mode}
import musicplayer/input/key.{type Key} import musicplayer/input/key.{type Key}
import musicplayer/logging/logging import musicplayer/logging/logging
import musicplayer/mpv/control as mpv_control import musicplayer/mpv/control as mpv_control
@@ -10,14 +10,9 @@ import musicplayer/time/time
import musicplayer/ui/control as ui_control import musicplayer/ui/control as ui_control
import musicplayer/ui/layout import musicplayer/ui/layout
type Input {
Input(capturing: Bool, content: String)
}
type State { type State {
State( State(
mode: Mode, mode: Mode,
input: Input,
ui: Subject(ui_control.Control), ui: Subject(ui_control.Control),
mpv: Subject(mpv_control.Control), mpv: Subject(mpv_control.Control),
) )
@@ -30,10 +25,8 @@ pub fn new(
) -> Result(Pid, String) { ) -> Result(Pid, String) {
let input_keys = process.named_subject(input_keys_name) let input_keys = process.named_subject(input_keys_name)
let input = Input(False, "")
case case
actor.new(State(control.Idle, input, ui, mpv)) actor.new(State(control.Idle, ui, mpv))
|> actor.on_message(handle_message) |> actor.on_message(handle_message)
|> actor.start |> actor.start
{ {
@@ -43,7 +36,7 @@ pub fn new(
logging.log("musicplayer - started") logging.log("musicplayer - started")
process.spawn(fn() { process.spawn(fn() {
let assert Ok(_) = process.register(process.self(), input_keys_name) let assert Ok(_) = process.register(process.self(), input_keys_name)
handle_key(musicplayer, input_keys) forward_key(musicplayer, input_keys)
}) })
process.spawn(fn() { update_playback_time_loop(mpv, ui, 250) }) process.spawn(fn() { update_playback_time_loop(mpv, ui, 250) })
@@ -53,104 +46,58 @@ pub fn new(
} }
} }
fn handle_message(state: State, control: Control) -> actor.Next(State, Control) { fn handle_message(state: State, key: Key) -> actor.Next(State, Key) {
case control { case control.from_key(key, state.mode) {
control.InputKey(key) -> { Error(_) -> actor.continue(state)
let _ = control.from_key(key, state.mode) Ok(c) ->
// TODO get control and send it back to self case c {
actor.continue(state) control.Search(input, capturing) -> {
} case capturing {
True -> {
logging.log("musicplayer - searching: " <> input)
control.Search -> { update_search(state.ui, "searching: " <> input)
logging.log("musicplayer - initiating search")
update_search(state.ui, "searching: ") actor.continue(State(..state, mode: control.Searching(input)))
}
False -> {
logging.log(
"musicplayer - recieved return. `input`: "
<> "'"
<> input
<> "'",
)
actor.continue( update_search(state.ui, "")
State(
..state,
mode: control.Searching,
input: Input(..state.input, capturing: True),
),
)
}
control.Raw(content) -> { actor.continue(State(..state, mode: control.Idle))
logging.log("musicplayer - recieved raw input: " <> content) }
let content = case state.mode {
control.Idle ->
case content {
"1" -> state.input.content
_ -> state.input.content
} }
control.Searching -> { }
let updated = state.input.content <> content control.TogglePlayPause -> {
update_search(state.ui, "searching: " <> updated) logging.log("musicplayer - toggling play/pause")
updated
process.send(state.mpv, mpv_control.TogglePlayPause)
update_playback_time(state.mpv, state.ui)
actor.continue(state)
}
control.Exit -> {
logging.log("musicplayer - initiating musicplayer shutdown")
// Close `mpv` socket
process.call(state.mpv, 1000, fn(reply_to) {
mpv_control.Exit(reply_to)
})
// Reset terminal state (show cursor etc.)
process.call(state.ui, 1000, fn(reply_to) {
ui_control.Exit(reply_to)
})
logging.log("musicplayer - stopped")
actor.stop()
} }
} }
actor.continue(State(..state, input: Input(..state.input, content:)))
}
control.Backspace -> {
logging.log(
"musicplayer - recieved backspace. mode:" <> string.inspect(state.mode),
)
let content = case state.mode {
control.Idle -> state.input.content
control.Searching -> {
let updated = string.drop_end(state.input.content, 1)
update_search(state.ui, "searching: " <> updated)
updated
}
}
actor.continue(State(..state, input: Input(..state.input, content:)))
}
control.Return -> {
logging.log(
"musicplayer - recieved return. `input.capture`: "
<> "'"
<> state.input.content
<> "'",
)
// Note: state.input.content is now the final input, use it
// before it is reset
case state.mode {
control.Idle -> Nil
control.Searching -> update_search(state.ui, "")
}
actor.continue(
State(
..state,
mode: control.Idle,
input: Input(capturing: False, content: ""),
),
)
}
control.TogglePlayPause -> {
logging.log("musicplayer - toggling play/pause")
process.send(state.mpv, mpv_control.TogglePlayPause)
update_playback_time(state.mpv, state.ui)
actor.continue(state)
}
control.Exit -> {
logging.log("musicplayer - initiating musicplayer shutdown")
// Close `mpv` socket
process.call(state.mpv, 1000, fn(reply_to) { mpv_control.Exit(reply_to) })
// Reset terminal state (show cursor etc.)
process.call(state.ui, 1000, fn(reply_to) { ui_control.Exit(reply_to) })
logging.log("musicplayer - stopped")
actor.stop()
}
} }
} }
@@ -199,14 +146,14 @@ fn update_search(ui: Subject(ui_control.Control), content: String) -> Nil {
process.send(ui, ui_control.UpdateState(layout.Search, content)) process.send(ui, ui_control.UpdateState(layout.Search, content))
} }
/// `handle_key` listens to a subject onto which `input` will send messages with `Key`s /// `forward_key` listens to a subject onto which `input` will send messages with `Key`s
fn handle_key(musicplayer: Subject(Control), input_keys: Subject(Key)) -> Nil { /// that is then forwarded to the `musicplayer` agent to handle
fn forward_key(musicplayer: Subject(Key), input_keys: Subject(Key)) -> Nil {
let _ = let _ =
process.new_selector() process.new_selector()
|> process.select(input_keys) |> process.select(input_keys)
|> process.selector_receive_forever |> process.selector_receive_forever
|> fn(key) { control.InputKey(key) }
|> process.send(musicplayer, _) |> process.send(musicplayer, _)
handle_key(musicplayer, input_keys) forward_key(musicplayer, input_keys)
} }

View File

@@ -7,6 +7,5 @@ pub type Control {
UpdateState(section: Section, content: String) UpdateState(section: Section, content: String)
SetView(view_idx: layout.ViewIdx) SetView(view_idx: layout.ViewIdx)
// NodeEvent
Exit(reply_to: Subject(Nil)) Exit(reply_to: Subject(Nil))
} }

View File

@@ -1,11 +1,9 @@
import gleam/dict import gleam/dict
import gleam/int
import gleam/list import gleam/list
import gleam/pair import gleam/pair
import gleam/set import gleam/set
import gleam/string import gleam/string
import musicplayer/logging/logging
import musicplayer/ui/internal import musicplayer/ui/internal
import musicplayer/ui/plot.{type Buffer} import musicplayer/ui/plot.{type Buffer}

View File

@@ -1,7 +1,7 @@
import gleam/list import gleam/list
import gleeunit import gleeunit
import musicplayer/control.{type Control} import musicplayer/control.{type Control, type Mode}
import musicplayer/input/key.{type Key, Char} import musicplayer/input/key.{type Key, Char}
pub fn main() -> Nil { pub fn main() -> Nil {
@@ -9,16 +9,24 @@ pub fn main() -> Nil {
} }
type TestCase { type TestCase {
TestCase(key: Key, expected: Result(Control, Nil)) TestCase(key: Key, mode: Mode, expected: Result(Control, Nil))
} }
pub fn control_from_key_test() { pub fn control_from_key_test() {
let test_cases = [ let idle_tests = [
TestCase(Char(" "), Ok(control.TogglePlayPause)), TestCase(Char(" "), control.Idle, Ok(control.TogglePlayPause)),
TestCase(Char("q"), Ok(control.Exit)), TestCase(Char("/"), control.Idle, Ok(control.Search("", True))),
TestCase(Char("q"), control.Idle, Ok(control.Exit)),
] ]
list.each(test_cases, fn(tc) { let search_tests = [
assert tc.expected == control.from_key(tc.key) TestCase(Char("a"), control.Searching(""), Ok(control.Search("a", True))),
TestCase(Char("b"), control.Searching("a"), Ok(control.Search("ab", True))),
]
let test_cases = [idle_tests, search_tests]
list.each(list.flatten(test_cases), fn(tc) {
assert tc.expected == control.from_key(tc.key, tc.mode)
}) })
} }