Move styling to style and add Border type

By forwarding all `Key`s to the agent and allow it to decide what should
be done, instead of converting the `Key` to a `Control` and then decide
what should be done

src/musicplayer/control.gleam

@@ -1,19 +1,18 @@
+import gleam/string
+import musicplayer/ui/layout
+
 import musicplayer/input/key.{type Key}
 
 pub type Mode {
   Idle
-  Searching
+  Searching(input: String)
 }
 
 pub type Control {
-  InputKey(Key)
-
   TogglePlayPause
-  Search
+  Search(input: String, capturing: Bool)
 
-  Raw(String)
+  SetView(view_idx: layout.ViewIdx)
-  Return
-  Backspace
 
   Exit
 }
@@ -21,24 +20,39 @@ pub type Control {
 pub fn from_key(key: Key, mode: Mode) -> Result(Control, Nil) {
   case mode {
     Idle -> idle_from_key(key)
-    Searching -> todo
+    Searching(input) -> searching_from_key(key, input)
   }
 }
 
 pub fn idle_from_key(key: Key) -> Result(Control, Nil) {
   case key {
-    key.Return -> Ok(Return)
+    key.Char(char) -> {
-    key.Backspace -> Ok(Backspace)
+      case char {
-    key.Char(char) -> Ok(idle_char_control(char))
+        // Views are zero indexed
+        "1" -> Ok(SetView(0))
+        "2" -> Ok(SetView(1))
+
+        " " -> Ok(TogglePlayPause)
+        "/" -> Ok(Search(input: "", capturing: True))
+        "q" -> Ok(Exit)
+
+        // NOOP
+        _ -> Error(Nil)
+      }
+    }
+
+    // NOOP
     _ -> Error(Nil)
   }
 }
 
-fn idle_char_control(char: String) -> Control {
+pub fn searching_from_key(key: Key, input: String) -> Result(Control, Nil) {
-  case char {
+  case key {
-    " " -> TogglePlayPause
+    key.Char(char) -> Ok(Search(input <> char, True))
-    "/" -> Search
+    key.Backspace -> Ok(Search(string.drop_end(input, 1), True))
-    "q" -> Exit
+    key.Return -> Ok(Search(input, False))
-    _ -> Raw(char)
+
+    // NOOP
+    _ -> Error(Nil)
   }
 }

src/musicplayer/musicplayer.gleam

@@ -2,7 +2,7 @@ import gleam/erlang/process.{type Name, type Pid, type Subject}
 import gleam/otp/actor
 import gleam/string
 
-import musicplayer/control.{type Control, type Mode}
+import musicplayer/control.{type Mode}
 import musicplayer/input/key.{type Key}
 import musicplayer/logging/logging
 import musicplayer/mpv/control as mpv_control
@@ -10,14 +10,9 @@ import musicplayer/time/time
 import musicplayer/ui/control as ui_control
 import musicplayer/ui/layout
 
-type Input {
-  Input(capturing: Bool, content: String)
-}
-
 type State {
   State(
     mode: Mode,
-    input: Input,
     ui: Subject(ui_control.Control),
     mpv: Subject(mpv_control.Control),
   )
@@ -30,10 +25,8 @@ pub fn new(
 ) -> Result(Pid, String) {
   let input_keys = process.named_subject(input_keys_name)
 
-  let input = Input(False, "")
-
   case
-    actor.new(State(control.Idle, input, ui, mpv))
+    actor.new(State(control.Idle, ui, mpv))
     |> actor.on_message(handle_message)
     |> actor.start
   {
@@ -43,7 +36,7 @@ pub fn new(
       logging.log("musicplayer - started")
       process.spawn(fn() {
         let assert Ok(_) = process.register(process.self(), input_keys_name)
-        handle_key(musicplayer, input_keys)
+        forward_key(musicplayer, input_keys)
       })
 
       process.spawn(fn() { update_playback_time_loop(mpv, ui, 250) })
@@ -53,104 +46,67 @@ pub fn new(
   }
 }
 
-fn handle_message(state: State, control: Control) -> actor.Next(State, Control) {
+fn handle_message(state: State, key: Key) -> actor.Next(State, Key) {
-  case control {
+  case control.from_key(key, state.mode) {
-    control.InputKey(key) -> {
+    Error(_) -> actor.continue(state)
-      let _ = control.from_key(key, state.mode)
+    Ok(c) ->
-      // TODO get control and send it back to self
+      case c {
-      actor.continue(state)
+        control.SetView(view_idx) -> {
-    }
+          logging.log(
+            "musicplayer - setting current view to: "
+            <> string.inspect(view_idx),
+          )
 
-    control.Search -> {
+          update_current_view(state.ui, view_idx)
-      logging.log("musicplayer - initiating search")
+          actor.continue(state)
+        }
+        control.Search(input, capturing) -> {
+          case capturing {
+            True -> {
+              logging.log("musicplayer - searching: " <> input)
 
-      update_search(state.ui, "searching: ")
+              update_search(state.ui, "searching: " <> input)
 
-      actor.continue(
+              actor.continue(State(..state, mode: control.Searching(input)))
-        State(
+            }
-          ..state,
+            False -> {
-          mode: control.Searching,
+              logging.log(
-          input: Input(..state.input, capturing: True),
+                "musicplayer - recieved return. `input`: "
-        ),
+                <> "'"
-      )
+                <> input
-    }
+                <> "'",
+              )
 
-    control.Raw(content) -> {
+              update_search(state.ui, "")
-      logging.log("musicplayer - recieved raw input: " <> content)
 
-      let content = case state.mode {
+              actor.continue(State(..state, mode: control.Idle))
-        control.Idle ->
+            }
-          case content {
-            "1" -> state.input.content
-            _ -> state.input.content
           }
-        control.Searching -> {
+        }
-          let updated = state.input.content <> content
+        control.TogglePlayPause -> {
-          update_search(state.ui, "searching: " <> updated)
+          logging.log("musicplayer - toggling play/pause")
-          updated
+
+          process.send(state.mpv, mpv_control.TogglePlayPause)
+          update_playback_time(state.mpv, state.ui)
+          actor.continue(state)
+        }
+        control.Exit -> {
+          logging.log("musicplayer - initiating musicplayer shutdown")
+          // Close `mpv` socket
+          process.call(state.mpv, 1000, fn(reply_to) {
+            mpv_control.Exit(reply_to)
+          })
+
+          // Reset terminal state (show cursor etc.)
+          process.call(state.ui, 1000, fn(reply_to) {
+            ui_control.Exit(reply_to)
+          })
+
+          logging.log("musicplayer - stopped")
+
+          actor.stop()
         }
       }
-
-      actor.continue(State(..state, input: Input(..state.input, content:)))
-    }
-    control.Backspace -> {
-      logging.log(
-        "musicplayer - recieved backspace. mode:" <> string.inspect(state.mode),
-      )
-
-      let content = case state.mode {
-        control.Idle -> state.input.content
-        control.Searching -> {
-          let updated = string.drop_end(state.input.content, 1)
-          update_search(state.ui, "searching: " <> updated)
-          updated
-        }
-      }
-      actor.continue(State(..state, input: Input(..state.input, content:)))
-    }
-    control.Return -> {
-      logging.log(
-        "musicplayer - recieved return. `input.capture`: "
-        <> "'"
-        <> state.input.content
-        <> "'",
-      )
-
-      // Note: state.input.content is now the final input, use it
-      // before it is reset
-      case state.mode {
-        control.Idle -> Nil
-        control.Searching -> update_search(state.ui, "")
-      }
-
-      actor.continue(
-        State(
-          ..state,
-          mode: control.Idle,
-          input: Input(capturing: False, content: ""),
-        ),
-      )
-    }
-
-    control.TogglePlayPause -> {
-      logging.log("musicplayer - toggling play/pause")
-
-      process.send(state.mpv, mpv_control.TogglePlayPause)
-      update_playback_time(state.mpv, state.ui)
-      actor.continue(state)
-    }
-    control.Exit -> {
-      logging.log("musicplayer - initiating musicplayer shutdown")
-      // Close `mpv` socket
-      process.call(state.mpv, 1000, fn(reply_to) { mpv_control.Exit(reply_to) })
-
-      // Reset terminal state (show cursor etc.)
-      process.call(state.ui, 1000, fn(reply_to) { ui_control.Exit(reply_to) })
-
-      logging.log("musicplayer - stopped")
-
-      actor.stop()
-    }
   }
 }
 
@@ -178,7 +134,7 @@ fn update_playback_time(
     Error(err) ->
       process.send(
         ui,
-        ui_control.UpdateState(
+        ui_control.UpdateHeading(
           layout.PlaybackTime,
           "playback time: N/A (err: " <> err.details <> ")",
         ),
@@ -187,7 +143,7 @@ fn update_playback_time(
     Ok(mpv_control.PlaybackTime(data: playback_time)) ->
       process.send(
         ui,
-        ui_control.UpdateState(
+        ui_control.UpdateHeading(
           layout.PlaybackTime,
           "playback time: " <> time.to_duration_string(playback_time),
         ),
@@ -196,17 +152,24 @@ fn update_playback_time(
 }
 
 fn update_search(ui: Subject(ui_control.Control), content: String) -> Nil {
-  process.send(ui, ui_control.UpdateState(layout.Search, content))
+  process.send(ui, ui_control.UpdateHeading(layout.Search, content))
 }
 
-/// `handle_key` listens to a subject onto which `input` will send messages with `Key`s
+fn update_current_view(
-fn handle_key(musicplayer: Subject(Control), input_keys: Subject(Key)) -> Nil {
+  ui: Subject(ui_control.Control),
+  view_idx: layout.ViewIdx,
+) {
+  process.send(ui, ui_control.SetView(view_idx))
+}
+
+/// `forward_key` listens to a subject onto which `input` will send messages with `Key`s
+/// that is then forwarded to the `musicplayer` agent to handle
+fn forward_key(musicplayer: Subject(Key), input_keys: Subject(Key)) -> Nil {
   let _ =
     process.new_selector()
     |> process.select(input_keys)
     |> process.selector_receive_forever
-    |> fn(key) { control.InputKey(key) }
     |> process.send(musicplayer, _)
 
-  handle_key(musicplayer, input_keys)
+  forward_key(musicplayer, input_keys)
 }

src/musicplayer/ui/control.gleam

@@ -1,12 +1,11 @@
 import gleam/erlang/process.{type Subject}
 
-import musicplayer/ui/layout.{type Section}
+import musicplayer/ui/layout.{type Section, type ViewIdx}
 
 pub type Control {
   UpdateDimensions(columns: Int, rows: Int)
-  UpdateState(section: Section, content: String)
+  UpdateHeading(section: Section, heading: String)
-  SetView(view_idx: layout.ViewIdx)
+  SetView(view_idx: ViewIdx)
 
-  // NodeEvent
   Exit(reply_to: Subject(Nil))
 }

src/musicplayer/ui/layout.gleam

@@ -1,13 +1,14 @@
 import gleam/dict
 import gleam/int
 import gleam/list
+import gleam/option.{type Option, None, Some}
 import gleam/pair
 import gleam/set
 import gleam/string
 
-import musicplayer/logging/logging
 import musicplayer/ui/internal
 import musicplayer/ui/plot.{type Buffer}
+import musicplayer/ui/style.{type Style, Percent, Style}
 
 pub const root_section = "reserved_root_section"
 
@@ -19,18 +20,9 @@ pub type Section {
   PlaybackTime
 }
 
-pub type Dimension {
-  Percent(width: Int, height: Int)
-  // TODO add Flex that flows
-}
-
-pub type Style {
-  Style(dimensions: Dimension)
-}
-
 pub type Node {
-  Row(content: String, style: Style, children: List(Section))
+  Row(heading: Option(String), style: Style, children: List(Section))
-  Cell(content: String, style: Style)
+  Cell(heading: Option(String), style: Style)
 }
 
 pub type ViewIdx =
@@ -85,19 +77,24 @@ fn view_loop(i: ViewIdx, view_nodes: List(#(Section, Node))) -> View {
 
   dict.from_list(view_nodes)
   |> dict.insert(
-    Section(string.append("view_", string.inspect(i))),
+    view_index_section(i),
     Row(
-      content: "",
+      heading: None,
-      style: Style(dimensions: Percent(width: 100, height: 100)),
+      style: Style(dimensions: Percent(width: 100, height: 100), border: None),
       children: orphans,
     ),
   )
 }
 
-pub fn update_section(
+/// Takes a ViewIndex and create a Section key from it
+fn view_index_section(view_idx: ViewIdx) -> Section {
+  Section(string.append("view_", int.to_string(view_idx)))
+}
+
+pub fn update_section_heading(
   layout: Layout,
   section: Section,
-  content: String,
+  heading: String,
 ) -> Layout {
   case dict.get(layout.views, layout.current_view) {
     Error(_) -> layout
@@ -106,8 +103,8 @@ pub fn update_section(
         Error(_) -> layout
         Ok(node) -> {
           let updated_node = case node {
-            Cell(..) -> Cell(..node, content: content)
+            Cell(..) -> Cell(..node, heading: Some(heading))
-            Row(..) -> Row(..node, content: content)
+            Row(..) -> Row(..node, heading: Some(heading))
           }
 
           let updated_view = dict.insert(view, section, updated_node)
@@ -125,7 +122,7 @@ pub fn update_dimensions(layout: Layout, columns: Int, rows: Int) -> Layout {
   Layout(..layout, columns:, rows:)
 }
 
-pub fn set_view(layout: Layout, view_idx: ViewIdx) -> Layout {
+pub fn update_current_view(layout: Layout, view_idx: ViewIdx) -> Layout {
   Layout(..layout, current_view: view_idx)
 }
 
@@ -147,8 +144,7 @@ pub fn render(layout: Layout) -> Nil {
       render_loop(
         view,
         context,
-        // TODO extract to function `view_index`
+        view_index_section(layout.current_view),
-        Section(string.append("view_", string.inspect(layout.current_view))),
         buffer,
       )
       |> plot.flush_buffer(layout.columns, layout.rows)
@@ -200,15 +196,25 @@ pub fn render_loop(
         )
       }
 
-      let parent =
+      let parent = case node.heading {
-        plot.box(
+        None ->
-          buffer,
+          plot.box(
-          node_top_left_x,
+            buffer,
-          node_top_left_y,
+            node_top_left_x,
-          node_width,
+            node_top_left_y,
-          node_height,
+            node_width,
-        )
+            node_height,
-        |> plot.text(node.content, node_top_left_x, node_top_left_y)
+          )
+        option.Some(heading) ->
+          plot.box_with_heading(
+            buffer,
+            node_top_left_x,
+            node_top_left_y,
+            node_width,
+            node_height,
+            heading,
+          )
+      }
 
       case node {
         Cell(..) -> parent

src/musicplayer/ui/layout_examples/layout_examples.gleam

@@ -1,6 +1,9 @@
+import gleam/option.{Some}
+
 import musicplayer/ui/internal
-import musicplayer/ui/layout.{Percent, Section, Style}
+import musicplayer/ui/layout.{Section}
 import musicplayer/ui/layout_examples/wait_for_input.{wait_for_input}
+import musicplayer/ui/style.{Percent, Style}
 
 pub fn main() {
   let assert Ok(columns) = internal.io_get_columns()
@@ -21,8 +24,11 @@ fn two_rows_with_cells(columns: Int, rows: Int) -> layout.Layout {
       #(
         Section("Row1"),
         layout.Row(
-          content: "row 1",
+          heading: Some("row 1"),
-          style: Style(dimensions: Percent(width: 100, height: 50)),
+          style: Style(
+            dimensions: Percent(width: 100, height: 50),
+            border: Some(style.BorderSingle),
+          ),
           children: [
             Section("A"),
             Section("B"),
@@ -32,22 +38,31 @@ fn two_rows_with_cells(columns: Int, rows: Int) -> layout.Layout {
       #(
         Section("A"),
         layout.Cell(
-          content: "cell 1",
+          heading: Some("cell 1"),
-          style: Style(dimensions: Percent(width: 50, height: 50)),
+          style: Style(
+            dimensions: Percent(width: 50, height: 50),
+            border: Some(style.BorderSingle),
+          ),
         ),
       ),
       #(
         Section("B"),
         layout.Cell(
-          content: "cell 2",
+          heading: Some("cell 2"),
-          style: Style(dimensions: Percent(width: 50, height: 50)),
+          style: Style(
+            dimensions: Percent(width: 50, height: 50),
+            border: Some(style.BorderSingle),
+          ),
         ),
       ),
       #(
         Section("Row2"),
         layout.Row(
-          content: "row 2",
+          heading: Some("row 2"),
-          style: Style(dimensions: Percent(width: 50, height: 50)),
+          style: Style(
+            dimensions: Percent(width: 50, height: 50),
+            border: Some(style.BorderSingle),
+          ),
           children: [],
         ),
       ),

src/musicplayer/ui/plot.gleam

@@ -49,6 +49,19 @@ pub fn box(buffer: Buffer, x: Int, y: Int, width: Int, height: Int) -> Buffer {
   }
 }
 
+pub fn box_with_heading(
+  buffer: Buffer,
+  x: Int,
+  y: Int,
+  width: Int,
+  height: Int,
+  heading: String,
+) -> Buffer {
+  let heading_margin = 1
+  box(buffer, x, y, width, height)
+  |> text(heading, x + heading_margin, y)
+}
+
 fn horizontal_line(
   buffer: Buffer,
   x: Int,

src/musicplayer/ui/style.gleam

@@ -0,0 +1,34 @@
+import gleam/option.{type Option}
+
+pub type Dimension {
+  Percent(width: Int, height: Int)
+  // TODO add Flex that flows
+}
+
+pub type Border {
+  BorderNone
+  BorderSingle
+}
+
+pub type Style {
+  Style(dimensions: Dimension, border: Option(Border))
+}
+
+pub type BorderChars {
+  BorderChars(
+    top_left: String,
+    top_right: String,
+    bottom_left: String,
+    bottom_right: String,
+    horisontal: String,
+    vertical: String,
+  )
+}
+
+// https://en.wikipedia.org/wiki/Box-drawing_characters
+pub fn border_chars(border: Border) -> BorderChars {
+  case border {
+    BorderNone -> BorderChars("", "", "", "", "", "")
+    BorderSingle -> BorderChars("┌", "┐", "└", "┘", "─", "│")
+  }
+}

src/musicplayer/ui/ui.gleam

@@ -1,6 +1,7 @@
 import gleam/erlang/process.{type Subject}
 import gleam/int
 import gleam/list
+import gleam/option.{None, Some}
 import gleam/otp/actor
 import gleam/string
 
@@ -8,6 +9,7 @@ import musicplayer/logging/logging
 import musicplayer/ui/control.{type Control}
 import musicplayer/ui/internal
 import musicplayer/ui/layout.{type Layout}
+import musicplayer/ui/style
 
 pub type State(redraw, content) {
   State(redraw: Subject(Layout), layout: Layout)
@@ -23,33 +25,57 @@ pub fn new() -> Result(Subject(Control), String) {
         #(
           layout.Header,
           layout.Row(
-            content: "Foo (1) | Bar (2) | Baz (3)",
+            heading: Some("Foo <1> | Bar (2)"),
-            style: layout.Style(dimensions: layout.Percent(
+            style: style.Style(
-              width: 100,
+              dimensions: style.Percent(width: 100, height: 50),
-              height: 33,
+              border: Some(style.BorderSingle),
-            )),
+            ),
-            children: [],
-          ),
-        ),
-        #(
-          layout.Search,
-          layout.Row(
-            content: "",
-            style: layout.Style(dimensions: layout.Percent(
-              width: 100,
-              height: 33,
-            )),
             children: [],
           ),
         ),
         #(
           layout.PlaybackTime,
           layout.Row(
-            content: "00:00",
+            heading: None,
-            style: layout.Style(dimensions: layout.Percent(
+            style: style.Style(
-              width: 100,
+              dimensions: style.Percent(width: 100, height: 50),
-              height: 33,
+              border: Some(style.BorderSingle),
-            )),
+            ),
+            children: [],
+          ),
+        ),
+      ],
+      [
+        #(
+          layout.Header,
+          layout.Row(
+            heading: Some("Foo (1) | Bar <2>"),
+            style: style.Style(
+              dimensions: style.Percent(width: 100, height: 33),
+              border: Some(style.BorderSingle),
+            ),
+            children: [],
+          ),
+        ),
+        #(
+          layout.Search,
+          layout.Row(
+            heading: None,
+            style: style.Style(
+              dimensions: style.Percent(width: 100, height: 33),
+              border: Some(style.BorderSingle),
+            ),
+            children: [],
+          ),
+        ),
+        #(
+          layout.PlaybackTime,
+          layout.Row(
+            heading: None,
+            style: style.Style(
+              dimensions: style.Percent(width: 100, height: 33),
+              border: Some(style.BorderSingle),
+            ),
             children: [],
           ),
         ),
@@ -108,8 +134,8 @@ fn handle_message(
         }
       }
     }
-    control.UpdateState(section, content) -> {
+    control.UpdateHeading(section, heading) -> {
-      let layout = layout.update_section(state.layout, section, content)
+      let layout = layout.update_section_heading(state.layout, section, heading)
 
       actor.send(state.redraw, layout)
       actor.continue(State(..state, layout:))
@@ -121,7 +147,7 @@ fn handle_message(
       actor.stop()
     }
     control.SetView(view_idx) -> {
-      let layout = layout.set_view(state.layout, view_idx)
+      let layout = layout.update_current_view(state.layout, view_idx)
 
       actor.send(state.redraw, layout)
       actor.continue(State(..state, layout:))

test/musicplayer/control_test.gleam

@@ -1,7 +1,7 @@
 import gleam/list
 import gleeunit
 
-import musicplayer/control.{type Control}
+import musicplayer/control.{type Control, type Mode}
 import musicplayer/input/key.{type Key, Char}
 
 pub fn main() -> Nil {
@@ -9,16 +9,24 @@ pub fn main() -> Nil {
 }
 
 type TestCase {
-  TestCase(key: Key, expected: Result(Control, Nil))
+  TestCase(key: Key, mode: Mode, expected: Result(Control, Nil))
 }
 
 pub fn control_from_key_test() {
-  let test_cases = [
+  let idle_tests = [
-    TestCase(Char(" "), Ok(control.TogglePlayPause)),
+    TestCase(Char(" "), control.Idle, Ok(control.TogglePlayPause)),
-    TestCase(Char("q"), Ok(control.Exit)),
+    TestCase(Char("/"), control.Idle, Ok(control.Search("", True))),
+    TestCase(Char("q"), control.Idle, Ok(control.Exit)),
   ]
 
-  list.each(test_cases, fn(tc) {
+  let search_tests = [
-    assert tc.expected == control.from_key(tc.key)
+    TestCase(Char("a"), control.Searching(""), Ok(control.Search("a", True))),
+    TestCase(Char("b"), control.Searching("a"), Ok(control.Search("ab", True))),
+  ]
+
+  let test_cases = [idle_tests, search_tests]
+
+  list.each(list.flatten(test_cases), fn(tc) {
+    assert tc.expected == control.from_key(tc.key, tc.mode)
   })
 }

test/musicplayer/ui/layout_test.gleam

@@ -1,11 +1,13 @@
 import gleam/dict
 import gleam/io
+import gleam/option.{Some}
 import gleam/string
 import gleeunit
 import gleeunit/should
 
-import musicplayer/ui/layout.{Percent, RenderContext, Section, Style}
+import musicplayer/ui/layout.{RenderContext, Section}
 import musicplayer/ui/plot
+import musicplayer/ui/style.{Percent, Style}
 
 pub fn main() -> Nil {
   gleeunit.main()
@@ -17,8 +19,11 @@ pub fn percent_layout_test() {
       #(
         Section("Row1"),
         layout.Row(
-          content: "row 1",
+          heading: Some("row 1"),
-          style: Style(dimensions: Percent(width: 100, height: 50)),
+          style: Style(
+            dimensions: Percent(width: 100, height: 50),
+            border: Some(style.BorderSingle),
+          ),
           children: [
             Section("A"),
             Section("B"),
@@ -28,22 +33,31 @@ pub fn percent_layout_test() {
       #(
         Section("A"),
         layout.Cell(
-          content: "cell 1",
+          heading: Some("cell 1"),
-          style: Style(dimensions: Percent(width: 50, height: 100)),
+          style: Style(
+            dimensions: Percent(width: 50, height: 100),
+            border: Some(style.BorderSingle),
+          ),
         ),
       ),
       #(
         Section("B"),
         layout.Cell(
-          content: "cell 2",
+          heading: Some("cell 2"),
-          style: Style(dimensions: Percent(width: 50, height: 100)),
+          style: Style(
+            dimensions: Percent(width: 50, height: 100),
+            border: Some(style.BorderSingle),
+          ),
         ),
       ),
       #(
         Section("Row2"),
         layout.Row(
-          content: "row 1",
+          heading: Some("row 1"),
-          style: Style(dimensions: Percent(width: 100, height: 50)),
+          style: Style(
+            dimensions: Percent(width: 100, height: 50),
+            border: Some(style.BorderSingle),
+          ),
           children: [],
         ),
       ),
@@ -57,8 +71,8 @@ pub fn percent_layout_test() {
   let expected =
     "
 ┌──────────────────────────────────────────────────────────────────────────────┐
-│row 1────────────────────────────────────────────────────────────────────────┐│
+│┌row 1───────────────────────────────────────────────────────────────────────┐│
-││cell 1───────────────────────────────┐cell 2───────────────────────────────┐││
+││┌cell 1──────────────────────────────┐┌cell 2──────────────────────────────┐││
 │││                                    ││                                    │││
 │││                                    ││                                    │││
 │││                                    ││                                    │││
@@ -66,7 +80,7 @@ pub fn percent_layout_test() {
 │││                                    ││                                    │││
 ││└────────────────────────────────────┘└────────────────────────────────────┘││
 │└────────────────────────────────────────────────────────────────────────────┘│
-│row 1────────────────────────────────────────────────────────────────────────┐│
+│┌row 1───────────────────────────────────────────────────────────────────────┐│
 ││                                                                            ││
 ││                                                                            ││
 ││                                                                            ││